Add netstandard2.1 target and update DiagnosticSource dependency
#2679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
🔍 Preview links for changed docs |
|
I updated to the .NET 9 SDK and that I suspect is triggering the new formatting warnings, but I'm not entirely sure why. Will work on resolving those. |
stevejgordon
force-pushed
the
2657-netstandard
branch
2 times, most recently
from
8d5b054 to
5ddfaca
Compare
|
Working on the test failures. The IIS ones suggest we might still have to ship an older DiagnosticsSource build too, although I need to investigate why exactly based on our packaging process. |
stevejgordon
force-pushed
the
2657-netstandard
branch
7 times, most recently
from
067043d to
b99f3da
Compare
stevejgordon
force-pushed
the
2657-netstandard
branch
2 times, most recently
from
e8607fd to
c9b0b45
Compare
stevejgordon
force-pushed
the
2657-netstandard
branch
from
2b6ca25 to
b5fba58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2657
Fixes #2445
This adds a
netstandard2.1target so that features such as OTel bridge are available on older runtimes, even though those are out of support. This prevents an update of our package, without a runtime update, breaking/removing features. Features may still not be 100% compatible with older unsupported runtimes, but should work in general.As part of this, I updated the minimum dependency for
System.Diagnostics.DiagnosticSourcewhich is no generally 8.0.0. We still ship a version ofElastic.Apmand loader for the Startup hooks zip file which are built against 6.0.0. These support older unsupported runtimes although with no official testing.NOTE: We DOT NOT update
System.Diagnostics.DiagnosticSourceonnet462andnet472. While this worked and tested fine in local dev, it fails the IIS tests in CI. For now, we leave the version in these targets unchanged from 5.0.0. This is likely fine as we do not depend on any newer APIs in those targets.Compiler pre-processor directives now prefer
NETover a specific .NET version. We also addNETSTANDARD2_1so that features continue to work on older runtimes without a specific .NET target, i.e. 6 and 7.Docs PR to follow.